fix(date-picker): adjust style selectors for disabled or prev/next days #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Jan 17, 2020
abbeyhrt
changed the title
|
Deploy preview for carbon-elements failed. Built with commit 1c54c8d https://app.netlify.com/sites/carbon-elements/deploys/5e21fc168b91b40008362d6b |
|
Deploy preview for the-carbon-components ready! Built with commit 23b34a9 https://deploy-preview-5085--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 23b34a9 https://deploy-preview-5085--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 23b34a9 |
dakahn
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3434
This PR adjusts the selectors for disabled dates and changes the font color from
$ui-05->$disabled-02. It also changes the selector for previos month days and next month's days so they're visually applied and changes the font color to$text-02to$text-05since$text-02's value was recently changed.Before:
DatePicker with these changes:
Changelog
Changed
Testing / Reviewing
Check the
range calendar with min/max datesstory to see the disabled dates and and the greyed out next/previous month's days to see if they look as expected