feat(data-table): add colSpan prop for TableHeader #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
force-pushed
the
2491-add-colSpan-to-th
branch
from
2deae07
to
6f59e59
Compare
|
Deploy preview for the-carbon-components ready! Built with commit 2deae07 https://deploy-preview-5088--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2deae07 |
|
Deploy preview for carbon-components-react failed. Built with commit 2deae07 https://app.netlify.com/sites/carbon-components-react/deploys/5e22234af1b9ea00087c3af1 |
|
Deploy preview for the-carbon-components ready! Built with commit 6f59e59 https://deploy-preview-5088--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 6f59e59 https://deploy-preview-5088--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6f59e59 |
dakahn
approved these changes
Jan 17, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2491
Addresses #2491 by placing the
colSpanprop on<th>instead of the underlying<button>.Changelog
New
Changed
colSpansupport on<th>forTableHeaderRemoved