-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(listbox): set default title attributes to item text #5102
fix(listbox): set default title attributes to item text #5102
Conversation
647531b
to
5b1176f
Compare
Deploy preview for the-carbon-components ready! Built with commit 647531b https://deploy-preview-5102--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 647531b https://deploy-preview-5102--carbon-components-react.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 647531b https://app.netlify.com/sites/carbon-elements/deploys/5e25f172832e8d0008b408a1 |
Deploy preview for carbon-elements ready! Built with commit 0108486 |
Deploy preview for carbon-components-react ready! Built with commit 0108486 https://deploy-preview-5102--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit 0108486 https://deploy-preview-5102--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, able to see the title on truncated text 👍 ✅
Closes #4495
Closes #4507
This PR sets the default
title
attribute for listbox menu items to be the item text so the full text can be viewed even if it is truncated in the menu. Users that have customitemToString
functions will need to implement this themselves though. The dropdown story has been updated to include an exampleTesting / Reviewing
Ensure the full listbox menu item text is visible on all listbox components (combobox/dropdown/multiselect/filterable multiselect)