chore(notification): fix variable typo in component #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
abbeyhrt
approved these changes
Jan 20, 2020
joshblack
approved these changes
Jan 20, 2020
|
Deploy preview for the-carbon-components ready! Built with commit 10993ec https://deploy-preview-5106--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 10993ec |
|
Deploy preview for carbon-components-react ready! Built with commit 10993ec https://deploy-preview-5106--carbon-components-react.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small typo in a variable used within the
Notificationcomponent. It shouldn't affect end users at all, because the variable is only used privately inside the component.I named this a
chorebecause of the nature of the change but let me know if you want it named something else 👍Changelog
Changed