Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tabs): un-comment hidden proptype #5120

Merged
merged 2 commits into from
Jan 21, 2020
Merged

docs(tabs): un-comment hidden proptype #5120

merged 2 commits into from
Jan 21, 2020

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Jan 21, 2020

Closes #5105

Changelog

Changed

@jendowns jendowns requested a review from a team as a code owner January 21, 2020 17:00
@ghost ghost requested review from aledavila and tw15egan January 21, 2020 17:01
@jendowns jendowns changed the title fix(tabs): un-comment hidden prop to be add to root elem fix(tabs): un-comment hidden proptype Jan 21, 2020
@jendowns
Copy link
Contributor Author

Unsure if this should be a docs or fix type of change 😅 Let me know what you prefer!

@jendowns jendowns changed the title fix(tabs): un-comment hidden proptype docs(tabs): un-comment hidden proptype Jan 21, 2020
@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for the-carbon-components ready!

Built with commit 46e7c4d

https://deploy-preview-5120--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-elements ready!

Built with commit 46e7c4d

https://deploy-preview-5120--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-components-react failed.

Built with commit 46e7c4d

https://app.netlify.com/sites/carbon-components-react/deploys/5e27820d3491eb000901fd95

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with a docs change 👍 ✅

@tw15egan tw15egan merged commit 3b24b09 into carbon-design-system:master Jan 21, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs]: React component has commented out & unused prop hidden
4 participants