feat(box-shadow): remove deprecated layer, use box-shadow mixin #5126
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 5893c8e https://deploy-preview-5126--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 5893c8e |
|
Deploy preview for carbon-components-react failed. Built with commit 5893c8e https://app.netlify.com/sites/carbon-components-react/deploys/5e27914d4287750009899602 |
|
Deploy preview for the-carbon-components ready! Built with commit 0df272c https://deploy-preview-5126--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 0df272c https://app.netlify.com/sites/carbon-components-react/deploys/5e28cadbc21b010007b0d253 |
|
Deploy preview for carbon-elements ready! Built with commit 0df272c |
asudoh
requested review from
a team and
designertyler
and removed request for
a team
asudoh
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
|
Shouldn't this have been a breaking change? |
|
Hi @vprasanth! 👋 It definitely seems like there was some miscommunication around this mixin, it was deprecated for the v9 -> v10 transition but that may not have been communicated when folks were migrating. In v10 we ended up removing it after the deprecation since it is no longer useful in the new design language. |
|
this also bit one of our projects as we had relied on it existing. for now we are going to pin our dependency package to |
|
Note for folks commenting on this PR, created a new PR to reintroduce this mixin and then add an official deprecation path for this utility: #5812 |
Based on #2079 (comment)
layerwas supposed to be deprecated with the v10 release. This removes references to thelayermixin and relies on the ol'box-shadowmixin instead.This can be deferred to a larger release, but I wanted to get it in so that it is not get forgotten again.
Changelog
Changed
@include layer('overlay');are changed to@include box-shadow;Removed
$css--use-layer: true !default;src/globals/scss/_layer.scssfile.@import '../../globals/scss/layer';, many of which were unused in the file.Testing / Reviewing
Ensure components like Dropdown and Tooltip still have box shadows.