Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatable): add padding so search clear button doesn't obstruct text #5145

Merged
merged 11 commits into from
Jan 27, 2020
Merged

fix(datatable): add padding so search clear button doesn't obstruct text #5145

merged 11 commits into from
Jan 27, 2020

Conversation

tw15egan
Copy link
Member

Closes #5142

Adds right padding to more clearly mimic the default search behavior. This will make sure the search text does not tuck under the close button.

Changelog

Changed

  • Add padding to the right of the search input

Removed

  • weird style bug on a persistent search box

Screen Shot 2020-01-22 at 2 16 31 PM

Testing / Reviewing

Add lots of text to a data table toolbar search input and ensure it stops before the close button

@tw15egan tw15egan requested a review from a team as a code owner January 22, 2020 22:19
@ghost ghost requested review from asudoh and joshblack January 22, 2020 22:19
@asudoh asudoh requested review from a team and laurenmrice and removed request for a team January 22, 2020 22:21
@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for the-carbon-components ready!

Built with commit 073db0b

https://deploy-preview-5145--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-elements failed.

Built with commit a8f0c37

https://app.netlify.com/sites/carbon-elements/deploys/5e28ca8617fd9c00097628ad

@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 5c2a8c2

https://deploy-preview-5145--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-elements failed.

Built with commit 073db0b

https://app.netlify.com/sites/carbon-elements/deploys/5e28ca76dc908c0008dcce89

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for carbon-components-react failed.

Built with commit 073db0b

https://app.netlify.com/sites/carbon-components-react/deploys/5e28ca76d04f0500088745dc

@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 5c2a8c2

https://deploy-preview-5145--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 22, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 5c2a8c2

https://deploy-preview-5145--carbon-components-react.netlify.com

@abbeyhrt
Copy link
Contributor

abbeyhrt commented Jan 23, 2020 •
edited
Loading

@tw15egan This isn't coming from this PR but i noticed that the focus for the search clear button is off:
Screen Shot 2020-01-23 at 1 39 21 PM
would we want to address that in this PR too or do it in a separate PR/issue?

@tw15egan
Copy link
Member Author

@abbeyhrt should be fixed now! Good catch 👍

emyarod
emyarod approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

laurenmrice
laurenmrice approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🙌🏻

asudoh
asudoh approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh merged commit c39173f into carbon-design-system:master Jan 27, 2020
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@tw15egan tw15egan mentioned this pull request Feb 18, 2020
Closed
2 tasks
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@tw15egan tw15egan deleted the data-table-style-fixes branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@emyarod emyarod emyarod approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable ToolbarSearch: long input texts overlap with the 'x' btn.
5 participants
@tw15egan @abbeyhrt @asudoh @emyarod @laurenmrice