feat: add Esc key support to dismiss tooltips #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 6e66c13 https://deploy-preview-5147--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6e66c13 |
|
Deploy preview for carbon-components-react failed. Built with commit 6e66c13 https://app.netlify.com/sites/carbon-components-react/deploys/5e2f6c1b67651a000b4b0a43 |
asudoh
requested review from
a team and
designertyler
and removed request for
a team
asudoh
approved these changes
Jan 23, 2020
packages/components/src/components/tooltip/tooltip--definition.js
Outdated
Show resolved
Hide resolved
packages/components/src/components/tooltip/tooltip--definition.js
Outdated
Show resolved
Hide resolved
packages/components/src/components/tooltip/tooltip--definition.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/TooltipDefinition/TooltipDefinition.js
Outdated
Show resolved
Hide resolved
emyarod
force-pushed
the
3615-definition-tooltip-dismiss-esc
branch
from
5e55791
to
defed0c
Compare
|
Thank you for the updates @emyarod! |
emyarod
force-pushed
the
3615-definition-tooltip-dismiss-esc
branch
from
9ea4bd9
to
ad2bf18
Compare
designertyler
force-pushed
the
3615-definition-tooltip-dismiss-esc
branch
from
aab6ae7
to
ad2bf18
Compare
aledavila
approved these changes
Jan 27, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3615
Refs w3c/aria-practices#127 w3c/wcag#914 w3c/wcag#915
This PR adds Esc key support to dismiss all visible definition and icon tooltips. It appears that the pattern is still a work in progress on the w3c's end, so we will need to monitor the threads above to watch for any new changes or developments
Changelog
New
bx--tooltip--hiddenclass, applied for when the tooltip needs to be explicitly hidden (by esc key press)mouseenterandkeydownevents to correctly apply and remove the class depending on if a tooltip can/should be displayedTesting / Reviewing
trigger a tooltip (or multiple tooltips) by hover and/or focus and dismiss them with Esc, ensure that tooltips are still usable as intended