-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FilterableMultiSelect): open item list when searching #5192
fix(FilterableMultiSelect): open item list when searching #5192
Conversation
Deploy preview for the-carbon-components ready! Built with commit 08b3b65 https://deploy-preview-5192--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 08b3b65 |
Deploy preview for carbon-components-react failed. Built with commit 08b3b65 https://app.netlify.com/sites/carbon-components-react/deploys/5e30820f54c2540008e4cfa4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @emyarod!
5ce7916
to
4d8299d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #5002
This PR opens the item list for filterable multiselects when the input value changes so that the component will not be stuck in a state where users are modifying the input value and the item list will not appear
Testing / Reviewing