Also add ref to non-sortable branch in TableHeader #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from carbon-design-system
Chore: get carbon-design-system/master
merge with sds-master
ghost
requested review from
gmoehler
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit 4c22775 https://deploy-preview-5204--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 4c22775 https://app.netlify.com/sites/carbon-components-react/deploys/5e330e8cb9c25903ff3a3ce3 |
|
Deploy preview for carbon-elements ready! Built with commit 4c22775 |
|
BTW could you fix the code format? Thanks! |
joshblack
suggested changes
Jan 29, 2020
Co-Authored-By: Josh Black <josh@josh.black>
|
@asudoh The react deployment probably needs a re-start |
joshblack
approved these changes
Jan 30, 2020
tw15egan
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4876 (well actually it is already closed we are still adding to it ;-) , maybe should re-open it?)
#4877 added forward refs to the
TableHeaderbut did forget to add the ref to one codebranch. This PR is fixing this issue.@tay1orjones
@asudoh