Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): update search icon to correct token #5222

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jan 30, 2020

Closes #5218

Changes search icon to correct token value.

Changelog

Changed

  • Correct token value for search icon color

Removed

  • old comment referring to a now non-existent z-index value

@tw15egan tw15egan requested a review from a team as a code owner January 30, 2020 22:50
@ghost ghost requested review from abbeyhrt and asudoh January 30, 2020 22:50
@netlify
Copy link

netlify bot commented Jan 30, 2020

Deploy preview for the-carbon-components ready!

Built with commit 0d89b99

https://deploy-preview-5222--the-carbon-components.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh requested review from a team and laurenmrice and removed request for a team January 30, 2020 23:13
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you ! 👍🏻

@netlify
Copy link

netlify bot commented Jan 30, 2020

Deploy preview for carbon-components-react ready!

Built with commit 0d89b99

https://deploy-preview-5222--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 30, 2020

Deploy preview for carbon-elements ready!

Built with commit 0d89b99

https://deploy-preview-5222--carbon-elements.netlify.com

@asudoh asudoh merged commit 51a3c0a into carbon-design-system:master Jan 31, 2020
@tw15egan tw15egan deleted the search-icon-fix branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[search] search icon should be icon-02 not icon-01
3 participants