Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-shell): remove role='menu' from ui-shell #5235

Merged
merged 6 commits into from
Jan 31, 2020
Merged

fix(ui-shell): remove role='menu' from ui-shell #5235

merged 6 commits into from
Jan 31, 2020

Conversation

tw15egan
Copy link
Member

Closes #3583
Closes #3590
Closes #3584

We erroneously had role="menu" implying an application menu.

Changelog

Removed

  • All references to role="menu" and 'role="menuitem"`

Testing / Reviewing

Make sure UI Shell still looks the same, and there are no new DAP errors.

@tw15egan tw15egan requested a review from a team as a code owner January 31, 2020 17:02
@ghost ghost requested review from emyarod and joshblack January 31, 2020 17:03
joshblack
joshblack approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@emyarod
Copy link
Member

emyarod commented Jan 31, 2020 •
edited
Loading

duplicate of #5234? I self assigned those tickets...will close in favor of this

emyarod
emyarod approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emyarod
Copy link
Member

emyarod commented Jan 31, 2020

couldn't add this in the review but I also edited this comment and removed the role on L222

@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit bbf65e2

https://deploy-preview-5235--the-carbon-components.netlify.com

@tw15egan
Copy link
Member Author

@emyarod updated

@netlify
Copy link

netlify bot commented Jan 31, 2020

Deploy preview for carbon-components-react failed.

Built with commit 4f5342e

https://app.netlify.com/sites/carbon-components-react/deploys/5e345de34e45400008246931

@netlify
Copy link

netlify bot commented Jan 31, 2020

Deploy preview for carbon-elements ready!

Built with commit 4f5342e

https://deploy-preview-5235--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit bbf65e2

https://app.netlify.com/sites/carbon-components-react/deploys/5e3487be48554e0008921853

@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit bbf65e2

https://deploy-preview-5235--carbon-elements.netlify.com

@asudoh asudoh merged commit eb9412f into carbon-design-system:master Jan 31, 2020
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@tw15egan tw15egan deleted the ui-shell-a11y-fix branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@emyarod emyarod emyarod approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
5 participants
@tw15egan @emyarod @joshblack @abbeyhrt @asudoh