fix(_header.scss): fixed head base nav with mobile first approach #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 11ab6d5 https://deploy-preview-5238--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements failed. Built with commit 8e4170b https://app.netlify.com/sites/carbon-elements/deploys/5e3df3f78462360008d24525 |
|
Deploy preview for carbon-components-react ready! Built with commit 8e4170b https://deploy-preview-5238--carbon-components-react.netlify.com |
asudoh
requested review from
a team and
jeanservaas
and removed request for
a team
emyarod
approved these changes
Feb 3, 2020
tw15egan
approved these changes
Feb 3, 2020
abbeyhrt
approved these changes
Feb 4, 2020
jeanservaas
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
@asudoh looks like react deploy failed but I really don't want to hold this PR up, seems like a clear fix, I will trust that it's just a matter of getting the menu items to appear correctly at the exact 1056 breakpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5157
This issue describes how no navigation is shown exactly at 1056px width. This is due to how media queries are applied.
Changelog
Changed
@asudoh please review