Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tabs): add example CodeSnippet via renderContent to story #5258

Merged
merged 9 commits into from
Feb 4, 2020
Merged

docs(tabs): add example CodeSnippet via renderContent to story #5258

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfdba7b
docs(tabs): add example code snippet using renderContent to story
jendowns Feb 4, 2020
45af59c
Merge branch 'master' into 5257_tabs-story
jendowns Feb 4, 2020
02e5076
docs(tabs): add notes about renderContent prop
jendowns Feb 4, 2020
b45cb82
chore(tabs): apply formatting to story
jendowns Feb 4, 2020
400c1a3
Merge branch 'master' into 5257_tabs-story
jendowns Feb 4, 2020
c5de01b
Merge branch 'master' into 5257_tabs-story
tw15egan Feb 4, 2020
924f2fb
Merge branch 'master' into 5257_tabs-story
tw15egan Feb 4, 2020
b67775e
docs(tabs): wrap story tab content in p elements
jendowns Feb 4, 2020
2b9e4e6
docs(tabs): adjust indentation of code snippet example
jendowns Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 45 additions & 2 deletions packages/react/src/components/Tabs/Tabs-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { withKnobs, boolean, number, text } from '@storybook/addon-knobs';
import { settings } from 'carbon-components';
import classNames from 'classnames';
import './Tabs-story.scss';
import CodeSnippet from '../CodeSnippet';
import Tabs from '../Tabs';
import Tab from '../Tab';
import TabsSkeleton from '../Tabs/Tabs.Skeleton';
Expand Down Expand Up @@ -51,6 +52,32 @@ const props = {

const CustomLabel = ({ text }) => <>{text}</>;

const CodeSnippetExample = () => (
<CodeSnippet type="multi">
{`@mixin grid-container {
width: 100%;
padding-right: padding(mobile);
padding-left: padding(mobile);

@include breakpoint(bp--xs--major) {
padding-right: padding(xs);
padding-left: padding(xs);
}
}

$z-indexes: (
modal : 9000,
overlay : 8000,
dropdown : 7000,
header : 6000,
footer : 5000,
hidden : - 1,
overflowHidden: - 1,
floating: 10000
);`}
</CodeSnippet>
);

const TabContentRenderedOnlyWhenSelected = ({
selected,
children,
Expand Down Expand Up @@ -88,7 +115,15 @@ storiesOf('Tabs', module)
{...props.tab()}
label="Tab label 4"
renderContent={TabContentRenderedOnlyWhenSelected}>
<div className="some-content">Content for fourth tab goes here.</div>
<div className="some-content">
<p>Content for fourth tab goes here.</p>
<p>
This example uses the&nbsp;
<CodeSnippet type="inline">renderContent</CodeSnippet> prop to
re-render content when the tab is selected.
</p>
<CodeSnippetExample />
</div>
</Tab>
<Tab
id="tab-5"
Expand Down Expand Up @@ -122,7 +157,15 @@ storiesOf('Tabs', module)
{...props.tab()}
label="Tab label 3"
renderContent={TabContentRenderedOnlyWhenSelected}>
<div className="some-content">Content for third tab goes here.</div>
<div className="some-content">
<p>Content for third tab goes here.</p>
tw15egan marked this conversation as resolved.
Show resolved Hide resolved
<p>
This example uses the&nbsp;
<CodeSnippet type="inline">renderContent</CodeSnippet> prop to
re-render content when the tab is selected.
</p>
<CodeSnippetExample />
</div>
</Tab>
<Tab
id="tab-4"
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Tabs/Tabs-story.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ $css--reset: false;
@import '~carbon-components/src/globals/scss/css--helpers';

.bx--tabs--container ~ div {
height: 320px;
min-height: 320px;
background-color: $ui-01;
}