-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): use currentColor as icon fill for all states #5270
fix(button): use currentColor as icon fill for all states #5270
Conversation
Deploy preview for carbon-elements ready! Built with commit 96beda4 |
Deploy preview for carbon-components-react failed. Built with commit 96beda4 https://app.netlify.com/sites/carbon-components-react/deploys/5e3c97092e9d4000096da03c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @janhassel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
I've noticed that in the button styles the icon path fill is initially set to
currentColor
but overwritten in most states (disabled, hover...) event hough thecolor
value changes the same.If this is intentional, I'd be interested in the reasoning behind it. Otherwise, this PR applies the same
currentColor
logic to the states.Changelog
Changed
Testing / Reviewing