fix(button): use currentColor as icon fill for all states #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 96beda4 |
|
Deploy preview for carbon-components-react failed. Built with commit 96beda4 https://app.netlify.com/sites/carbon-components-react/deploys/5e3c97092e9d4000096da03c |
asudoh
approved these changes
Feb 6, 2020
asudoh
requested review from
a team and
designertyler
and removed request for
a team
designertyler
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in the button styles the icon path fill is initially set to
currentColorbut overwritten in most states (disabled, hover...) event hough thecolorvalue changes the same.If this is intentional, I'd be interested in the reasoning behind it. Otherwise, this PR applies the same
currentColorlogic to the states.Changelog
Changed
Testing / Reviewing