fix(ui-shell): allow custom classes on HeaderSideNavItems #5275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit f1e5e4c |
|
Deploy preview for carbon-components-react failed. Built with commit f1e5e4c https://app.netlify.com/sites/carbon-components-react/deploys/5e3c5e14e6b60200089d9bc6 |
|
nitpick: There should be a unit test to cover this bug, as the current set of tests didn't catch it originally. |
dakahn
approved these changes
Feb 6, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5273
Ensures custom classes are properly passed down to
HeaderSideNavItemsChangelog
Changed
customClassNameout of the object so the custom class is correctly appliedTesting / Reviewing
Add
className="test"toHeaderSideNavItemsin theHeader Base w/ Navigationstory, and ensure the custom class is correctly applied