feat(Tooltip): add several ARIA attributes #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
This change adds several ARIA attributes along with `tooltipBodyId` prop, so element relationships are better described. This better aligns to the change made to vanilla earlier (carbon-design-system#3148 and Fixes carbon-design-system#3812.
asudoh
force-pushed
the
interactive-tooltip-markup-a11y
branch
from
512f22a
to
c1fe58c
Compare
|
Deploy preview for carbon-components-react ready! Built with commit 512f22a https://deploy-preview-5282--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 512f22a |
|
Deploy preview for carbon-components-react failed. Built with commit f1c03aa https://app.netlify.com/sites/carbon-components-react/deploys/5e3c827450a00300094e3364 |
|
Deploy preview for carbon-elements failed. Built with commit f1c03aa https://app.netlify.com/sites/carbon-elements/deploys/5e3c82746283d50008a0fc99 |
aledavila
approved these changes
Feb 6, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds several ARIA attributes along with
tooltipBodyIdprop, so element relationships are better described.This better aligns to the change made to vanilla earlier (#3148 and #3476).
No new DAP errors are observed.
Fixes #3812.
Changelog
New
tooltipBodyIdprop<Tooltip>Testing / Reviewing
Testing should make sure interactive tooltip is not broken.