fix(HeaderMenu): re-enabled links in submenu #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 3a4f186 |
|
Deploy preview for carbon-components-react failed. Built with commit 3a4f186 https://app.netlify.com/sites/carbon-components-react/deploys/5e41f7c1f7574800082baf68 |
|
Doesn't look like it is coming from this PR, but getting this console warning now when reviewing
If it is a larger fix we can move it to a separate PR |
|
@tw15egan You are right that the warning doesn't have to do with this change, but good catch. Fixed. |
emyarod
approved these changes
Feb 10, 2020
tw15egan
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4641.
Changelog
Changed
event.preventDefault()in theclickevent handler of<HeaderMenu>now only runs if the<HeaderMenu>itself is clicked on, not on sub-menus.Testing / Reviewing
Testing should make sure
<HeaderMenu>is not broken.