-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HeaderMenu): re-enabled links in submenu #5296
fix(HeaderMenu): re-enabled links in submenu #5296
Conversation
Deploy preview for carbon-elements ready! Built with commit 3a4f186 |
Deploy preview for carbon-components-react failed. Built with commit 3a4f186 https://app.netlify.com/sites/carbon-components-react/deploys/5e41f7c1f7574800082baf68 |
@tw15egan You are right that the warning doesn't have to do with this change, but good catch. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, submenu links are functioning correctly now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of the other issue as well 👍 ✅
Fixes #4641.
Changelog
Changed
event.preventDefault()
in theclick
event handler of<HeaderMenu>
now only runs if the<HeaderMenu>
itself is clicked on, not on sub-menus.Testing / Reviewing
Testing should make sure
<HeaderMenu>
is not broken.