FIX: New geometry 32 switcher, overflow menus #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjustments to 32/switcher and app-switcher, removed 16, 20, 24 variants
chrisconnors-ibm
requested review from
laurenmrice and
a team
as code owners
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 0496074 |
|
Deploy preview for carbon-components-react ready! Built with commit 0496074 https://deploy-preview-5314--carbon-components-react.netlify.com |
|
Would you mind keeping the deprecated assets btw? We currently still need them to support folks without doing a breaking change 😬 |
|
PR only removes 16/20/24 of app-switcher and switcher, overflow-menu--* (in order to test scaled outcomes of adjusted 32 assets), shouldn't break anything. |
|
Got it, my mistake! Thanks @chrisconnors-ibm |
adjusts spacing for overflow-menu--h and overflow-menu--v to divisible by 4; removes 16 variants
chrisconnors-ibm
changed the title
chrisconnors-ibm
changed the title
joshblack
approved these changes
Feb 14, 2020
aagonzales
approved these changes
Feb 14, 2020
conradennis
approved these changes
Feb 14, 2020
laurenmrice
approved these changes
Feb 14, 2020
abbeyhrt
approved these changes
Feb 14, 2020
|
What’s the mechanism that triggers a re-run of the plugin? Just a new issue? |
|
@chrisconnors-ibm yeah, we'll capture this with our other icon work, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spacing adjustments to 32/switcher and app-switcher, 32/overflow-menu--*, and removed 16, 20, 24 variants. adjustments reduce or eliminate the need for bespoke assets at the scaled sizes.
app-switcher:
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fapp-switcher
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fapp-switcher%20(Downsized%20to%2024)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fapp-switcher%20(Downsized%20to%2020)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fapp-switcher%20(Downsized%20to%2016)
switcher:
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fswitcher
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fswitcher%20(Downsized%20to%2024)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fswitcher%20(Downsized%20to%2020)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Fswitcher%20(Downsized%20to%2016)
overflow-menu--horizontal:
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--horizontal
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--horizontal%20(Downsized%20to%2024)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--horizontal%20(Downsized%20to%2020)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--horizontal%20(Downsized%20to%2016)
overflow-menu--vertical:
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--vertical
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--vertical%20(Downsized%20to%2024)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--vertical%20(Downsized%20to%2020)
https://deploy-preview-5314--carbon-elements.netlify.com/icons/examples/preview/#32%2Foverflow-menu--vertical%20(Downsized%20to%2016)