-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): ensure inline dropdown has transparent background #5322
fix(dropdown): ensure inline dropdown has transparent background #5322
Conversation
Deploy preview for carbon-components-react ready! Built with commit 53d51ce https://deploy-preview-5322--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 53d51ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @tw15egan!
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So inline dropdown actually should be transparent on enabled, it isn't supposed to have a background expect on hover/active.
(I still don't have a local build so I can't see it)
Hi @aagonzales just wanted to double-check if you can test it with https://deploy-preview-5322--carbon-components-react.netlify.com (given React deploy preview didn't fail)? If there was a different reason why you needed a local build my apologies. |
@asudoh It's still wrong. Inline dropdown shouldn't have a background color except on hover.It should be transparent and therefor will not need the light variant. |
@aagonzales Thank you for your response! @tw15egan Does what @aagonzales pointed out happen in your local dev env? |
6bfdf08
to
9da8749
Compare
9da8749
to
5680b68
Compare
@aagonzales that makes way more sense, not sure why I didn't do that in the first place. I blame dad brain 🤦♂ @asudoh ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super 🎉 - Thank you for your update @tw15egan!
🤦♂ forgot to change commit message, should have been |
Closes #5321
Sets the background of inline dropdowns to transparent so it will always appear correct no matter the background
Changelog
Changed
ui-background
totransparent
Testing / Reviewing
Ensure the inline dropdown does not have a background by manually setting a background color on the container of the inline dropdown.