feat(tooltip): add support for hoverable definition tooltip body #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit e78642a |
|
Deploy preview for carbon-components-react ready! Built with commit e78642a https://deploy-preview-5323--carbon-components-react.netlify.com |
emyarod
force-pushed
the
3616-definition-tooltip-hoverable
branch
2 times, most recently
from
185f31a
to
59249d0
Compare
joshblack
reviewed
Feb 24, 2020
| } | ||
| ); | ||
| const debounceTooltipVisible = debounce(() => setTooltipVisible(false), 100); |
There was a problem hiding this comment.
Do we need to debounce the exit? Are there any timing windows that we should be hitting for delays? Curious when we'd use 100/300/etc 🤔
There was a problem hiding this comment.
the 100ms delay value is arbitrary but debouncing the exit is what resolves the original issue. afaik there is no guidance on the delay since the guidelines are still WIP w3c/aria-practices#127 w3c/aria-practices#128
joshblack
approved these changes
Feb 24, 2020
emyarod
force-pushed
the
3616-definition-tooltip-hoverable
branch
from
ed84a6e
to
851fa31
Compare
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3616
This PR adds support for hoverable definition tooltip body so that users can now select the text in the tooltip
Changelog
New
.bx--tooltip--visibleclass which is applied and removed (debounced) based onmouseenter,mouseleave, and EsckeydowneventsChanged
focusevent handler tofocusinevent so that tooltips are correctly restored after Esc keypress and subsequent focusRemoved
pointer-events: nonerulesTesting / Reviewing
Ensure that definition tooltip body content is now selectable