fix(DatePicker): ensure down arrow opens calendar dropdown #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit f1137fa |
|
Deploy preview for carbon-components-react ready! Built with commit f1137fa https://deploy-preview-5326--carbon-components-react.netlify.com |
emyarod
approved these changes
Feb 12, 2020
joshblack
approved these changes
Feb 12, 2020
|
Should we add a quick test for this or is it already covered?? |
asudoh
force-pushed
the
date-picker-open-with-down-arrow
branch
from
7bf88e1
to
b687f80
Compare
|
Adding test makes sense - Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5310.
Changelog
New
<input>opens the calendar dropdown.Testing / Reviewing
Testing should make sure our date picker is not broken.