Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): reduce small ghost button left/right padding #5334

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 12, 2020

Closes #5329
Closes #5387

This PR reduces the side padding for small ghost buttons to match the other small button variants

@netlify
Copy link

netlify bot commented Feb 12, 2020

Deploy preview for carbon-elements ready!

Built with commit 5bee087

https://deploy-preview-5334--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 12, 2020

Deploy preview for carbon-components-react ready!

Built with commit 5bee087

https://deploy-preview-5334--carbon-components-react.netlify.com

@laurenmrice
Copy link
Member

can you deploy the previews again? I think they will work now since josh got them updated to 30 min.

@joshblack
Copy link
Contributor

@laurenmrice just triggered a rebuild!

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! checked in all themes, and firefox, chrome, safari 👍🏻

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@asudoh
Copy link
Contributor

asudoh commented Feb 19, 2020

Got a green light from @emyarod to move this to a "ready to merge" state - Thanks @emyarod!

@asudoh asudoh merged commit 5454ef5 into carbon-design-system:master Feb 19, 2020
@emyarod emyarod deleted the 5329-small-ghost-button-padding branch February 19, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect padding with small ghost Button Ghost button text should be left aligned
5 participants