-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): reduce small ghost button left/right padding #5334
fix(button): reduce small ghost button left/right padding #5334
Conversation
Deploy preview for carbon-elements ready! Built with commit 5bee087 |
Deploy preview for carbon-components-react ready! Built with commit 5bee087 https://deploy-preview-5334--carbon-components-react.netlify.com |
can you deploy the previews again? I think they will work now since josh got them updated to 30 min. |
@laurenmrice just triggered a rebuild! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ! checked in all themes, and firefox, chrome, safari 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @emyarod!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
e446472
to
5bee087
Compare
Closes #5329
Closes #5387
This PR reduces the side padding for small ghost buttons to match the other small button variants