docs(FormItem): remove FormItem story #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 97016af |
|
Deploy preview for carbon-components-react ready! Built with commit 97016af https://deploy-preview-5379--carbon-components-react.netlify.com |
tw15egan
force-pushed
the
form-item-removal
branch
from
f410634
to
2ba9bdb
Compare
emyarod
reviewed
Feb 18, 2020
|
@emyarod sounds good, I can update the PR to wrap |
|
@emyarod actually it seems like all of our form elements are already wrapped in
|
tw15egan
force-pushed
the
form-item-removal
branch
from
aac868c
to
2ba9bdb
Compare
joshblack
approved these changes
Feb 19, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4573
FormItemstory was not much help and was showing an incorrect example. It can possibly be added back in based on the outcome of #5367 when we go through and standardize default spacing on components.Changelog
Removed
FormItemstoryTesting / Reviewing
Make sure
FormItemstory does not show up in the storybook