Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): update Node.js version to v12 LTS #5391

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Feb 18, 2020

Motivation

Node 12 is the LTS version, we'll need to update eventually. This brings us in line with the theme/website minimum node versions as well.

Changelog

  • update all workflows to use node 12,
  • update min version in package.json to reflect 12
  • update scss-to-json v2 which removes its dependency on node-sass v3 which is node 12 incompatible.

@vpicone vpicone requested a review from a team as a code owner February 18, 2020 21:26
@ghost ghost requested review from dakahn and joshblack February 18, 2020 21:26
@netlify
Copy link

netlify bot commented Feb 18, 2020

Deploy preview for carbon-elements ready!

Built with commit fa7e12c

https://deploy-preview-5391--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 18, 2020

Deploy preview for carbon-components-react ready!

Built with commit fa7e12c

https://deploy-preview-5391--carbon-components-react.netlify.com

@joshblack
Copy link
Contributor

Yeesh, no idea what's going on with node-sass. If you end up needing to force one version that's totally fair, can place it in /package.json under resolutions with the other stuff 👍

@vpicone
Copy link
Contributor Author

vpicone commented Feb 18, 2020

@joshblack yeah not sure :/ it looks like we have a node-sass@3 in our yarn lock and offline mirrors for some reason not sure if it’s trying to build that?

@joshblack
Copy link
Contributor

@vpicone when looking at the error messages locally it seems like scss-to-json was the dependency causing issues and it had a nested node-sass in its node_modules, maybe it's something with that?

Can always try pinning it to the version we want to use too to see if that helps address it.

@vpicone
Copy link
Contributor Author

vpicone commented Feb 18, 2020

@joshblack ah nice that was it. Updating scss-to-json removed the dependency on node-sass v3.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any issues after updating 👍 ✅

@joshblack joshblack changed the title Use node 12 chore(project): update Node.js version to v12 LTS Feb 19, 2020
@joshblack joshblack merged commit a586deb into carbon-design-system:master Feb 19, 2020
@vpicone vpicone deleted the use-node-12 branch February 19, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants