fix(data-table): correct padding for batch action buttons #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
emyarod
requested review from
a team and
designertyler
and removed request for
a team
|
Deploy preview for carbon-components-react ready! Built with commit 2c838ae https://deploy-preview-5413--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2c838ae |
designertyler
approved these changes
Feb 21, 2020
asudoh
approved these changes
Feb 24, 2020
aledavila
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Sketch kit and on the carbon website, batch action buttons in the DataTable have an 8px gap between text and button (effectively using the same spacing as a ghost button). The
carbon-componentsstyling currently treats the spacing as a normal primary button.Changelog
Changed
$button-padding-ghostfor buttons in.bx--action-listposition: staticTesting / Reviewing
Resources
Screenshot from https://www.carbondesignsystem.com/components/data-table/usage#multi-select-batch-action
Screenshot from 7.9.3 react storybook
