chore: upgrade jest to incorporate jsdom bugfix #5456
Conversation
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit a4469c5 |
|
Deploy preview for carbon-components-react ready! Built with commit a4469c5 https://deploy-preview-5456--carbon-components-react.netlify.com |
|
re-requesting review due to some test refactoring (edited PR description for more context and added relevant tickets for context) |
|
I remove them in test suites where they are reused, but I can add the line to each modified individual test case https://github.com/carbon-design-system/carbon/pull/5456/files#diff-e6bde0b208435880662cb06911ee85c1R246 |
emyarod
force-pushed
the
upgrade-jest-25
branch
from
1b3c84e
to
e1599d5
Compare
|
Thank you for the update @emyarod! Given you added a clean-up code at the last line of each test case, it won't run if there are any assertions failures, etc. You could use a try ... catch block, but I tend to do: describe('suite', () => {
let div;
it('does the right thing', () => {
div = document.createElement('div');
document.body.appendChild(div);
(Your test)
});
afterEach(() => {
if (div && div.parentNode) {
div.parentNode.removeChild(div);
}
div = null;
});
});Note: Ensuring clean-up stuffs done after (each) tests avoids flaky tests. |
emyarod
force-pushed
the
upgrade-jest-25
branch
from
e1599d5
to
abaa7aa
Compare
emyarod
force-pushed
the
upgrade-jest-25
branch
from
abaa7aa
to
797bf4c
Compare
…#5456) * chore: upgrade jest * test: adjust for new document.activeElement behavior in jsdom * test: clean up container div Co-authored-by: Josh Black <josh@josh.black>
This PR upgrades Jest to the latest version (v25.1.0) in order to incorporate a
jsdombugfix. The outdatedjsdomdependency was causing test failures in ourFloatingMenucomponent due to an upstream bug which would dispatch afocusevent when thefocus()method was called on an already focused element, leading to endless cycling betweenfocusandblurevent handler calls. Discovered while working on #5365refs:
jsdom/jsdom#2621
jsdom/jsdom#2700
jsdomis also now handlingdocument.activeElementdifferently from previous versions, so some tests have been revised to account for that breaking changerefs:
ant-design/ant-design#21185
jsdom/jsdom#2586
jsdom/jsdom#2723
enzymejs/enzyme#2337
Testing / Reviewing
Ensure none of our tests are broken