fix(icons-build-helpers): remove will-change: transform from react icons #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Apr 3, 2020
|
Deploy preview for carbon-elements ready! Built with commit 9497f6c |
|
Deploy preview for carbon-components-react ready! Built with commit 17b38bc https://deploy-preview-5803--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 33515f0 https://deploy-preview-5803--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit a898340 https://deploy-preview-5803--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 9497f6c https://deploy-preview-5803--carbon-components-react.netlify.com |
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5274
Our react SVG's were still adding the
will-change: transformstyle, which was causing weird interaction errors. This removes that property from each icon that is generated inicon-build-helpersChangelog
Removed
will-change: transformto each icon processed inicons-reactTesting / Reviewing
Ensure the SVG's are not adding this property anymore. May need to run locally and build from the root directory.