Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): remove bespoke assets in preference of downsizing #6151

Merged

Conversation

joshblack
Copy link
Contributor

Closes #6137

Remove bespoke assets at 16x16 in preference of the 32x32 asset.

Changelog

New

Changed

Removed

  • Remove bespoke assets at 16x16 in preference of the 32x32 asset

Testing and reviewing

Verify that the following icons render correctly in the elements preview:

  • 16/help--filled
  • 16/information--filled
  • 16/warning--alt--filled

@joshblack joshblack requested a review from a team as a code owner May 27, 2020 19:14
@ghost ghost requested review from aledavila and emyarod May 27, 2020 19:14
@joshblack
Copy link
Contributor Author

FYI @laurenmrice

@netlify
Copy link

netlify bot commented May 27, 2020

Deploy preview for carbon-components-react ready!

Built with commit 2b62352

https://deploy-preview-6151--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented May 27, 2020

Deploy preview for carbon-elements ready!

Built with commit 2b62352

https://deploy-preview-6151--carbon-elements.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack joshblack merged commit 6db63e0 into carbon-design-system:master May 30, 2020
@joshblack joshblack deleted the 6137-remove-bespoke-icons branch May 30, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icons] remove bespoke 16px icons that should receive inner fill
3 participants