Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): add more stylelint rules #6445

Merged
merged 10 commits into from
Jul 23, 2020

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jul 10, 2020

Test out adding in new stylelint rules for the repo. Right now, spaces are not enforced between blocks, but we can turn that on if we think it is valuable to see the different blocks.

.declaration-order {
  /* Positioning */
  position: absolute;
  top: 0;
  right: 0;
  bottom: 0;
  left: 0;
  z-index: 10;

  /* Box Model */
  display: block;
  float: right;
  width: 100px;
  height: 100px;
  margin: 10px;
  padding: 10px;

  /* Typography */
  color: #888;
  font: normal 16px Helvetica, sans-serif;
  line-height: 1.3;
  text-align: center;

  /* Visual */
  background-color: #eee;
  border: 1px solid #888;
  border-radius: 4px;
  opacity: 1;

  /* Animation */
  transition: all 1s;

  /* Misc */
  user-select: none;
}

Changelog

New

  • stylelint-no-unsupported-browser-features
  • stylelint-config-rational-order

Changed

  • Ran stylelint --fix across the repo to reorder selectors to match the rule

Testing / Reviewing

Ensure styles are still rendering properly

@tw15egan tw15egan requested a review from joshblack July 10, 2020 20:43
@tw15egan tw15egan force-pushed the stylelint-updates branch 2 times, most recently from daa2d56 to 8ff5e75 Compare July 10, 2020 20:48
@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-elements ready!

Built with commit dcf17fb

https://deploy-preview-6445--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-elements ready!

Built with commit 8ff5e75

https://deploy-preview-6445--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-components-react ready!

Built with commit dcf17fb

https://deploy-preview-6445--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-elements ready!

Built with commit e478ca0

https://deploy-preview-6445--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit e478ca0

https://deploy-preview-6445--carbon-components-react.netlify.app

@tw15egan tw15egan force-pushed the stylelint-updates branch 3 times, most recently from 2a726f2 to 4fa1d84 Compare July 17, 2020 20:21
@tw15egan tw15egan marked this pull request as ready for review July 17, 2020 20:44
@tw15egan tw15egan requested a review from a team as a code owner July 17, 2020 20:44
@ghost ghost requested a review from andreancardona July 17, 2020 20:44
@tw15egan tw15egan requested a review from joshblack July 20, 2020 16:27
@andreancardona andreancardona self-assigned this Jul 21, 2020
@andreancardona
Copy link
Contributor

andreancardona commented Jul 21, 2020

@tw15egan Looks like there are some conflicts - otherwise looks good to me :)

@tw15egan
Copy link
Member Author

Merge conflicts are fixed, but let's wait until #6466 is merged in before we merge this 👍

@kodiakhq kodiakhq bot merged commit ee90f4e into carbon-design-system:master Jul 23, 2020
@tw15egan tw15egan deleted the stylelint-updates branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants