-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): update left and right gutter class names to start and end #6523
fix(grid): update left and right gutter class names to start and end #6523
Conversation
# Conflicts: # src/components/toggle/_toggle.scss # src/components/toggle/toggle--small.hbs # src/globals/scss/_theme-tokens.scss
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Deploy preview for carbon-elements ready! Built with commit fd25aa0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Deploy preview for carbon-components-react ready! Built with commit fc71179 https://deploy-preview-6523--carbon-components-react.netlify.app |
Deploy preview for carbon-components-react ready! Built with commit fd25aa0 https://deploy-preview-6523--carbon-components-react.netlify.app |
…nto add-grid-start-end * 'add-grid-start-end' of github.com:alisonjoseph/carbon: chore(project): sync generated files
@alisonjoseph seems like it's pulling in the |
Oops, I think I fixed it. 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore me! Just was a comment change
Closes #6510
Updates left/right grid class names to start and end
Changelog
New
Testing / Reviewing
Ensure nothing is broken.
Confirm this is the correct way to comment that the left/right should be deprecated??