Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): update left and right gutter class names to start and end #6523

Merged
merged 14 commits into from
Jul 23, 2020
Merged

fix(grid): update left and right gutter class names to start and end #6523

merged 14 commits into from
Jul 23, 2020

Conversation

alisonjoseph
Copy link
Member

Closes #6510

Updates left/right grid class names to start and end

Changelog

New

  • start / end classnames for grid gutter and hang

Testing / Reviewing

Ensure nothing is broken.

Confirm this is the correct way to comment that the left/right should be deprecated??

# Conflicts:
#	src/components/toggle/_toggle.scss
#	src/components/toggle/toggle--small.hbs
#	src/globals/scss/_theme-tokens.scss
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@netlify
Copy link

netlify bot commented Jul 22, 2020

Deploy preview for carbon-elements ready!

Built with commit fd25aa0

https://deploy-preview-6523--carbon-elements.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@netlify
Copy link

netlify bot commented Jul 22, 2020

Deploy preview for carbon-components-react ready!

Built with commit fc71179

https://deploy-preview-6523--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2020

Deploy preview for carbon-components-react ready!

Built with commit fd25aa0

https://deploy-preview-6523--carbon-components-react.netlify.app

@alisonjoseph alisonjoseph changed the title fix: update left and right gutter class names to start and end fix(grid): update left and right gutter class names to start and end Jul 22, 2020
alisonjoseph and others added 3 commits July 22, 2020 15:08
…nto add-grid-start-end

* 'add-grid-start-end' of github.com:alisonjoseph/carbon:
  chore(project): sync generated files
@tw15egan
Copy link
Member

@alisonjoseph seems like it's pulling in the narrow code from the other PR?

@alisonjoseph
Copy link
Member Author

Oops, I think I fixed it. 🤞

packages/grid/scss/_mixins.scss Show resolved Hide resolved
packages/grid/scss/_mixins.scss Show resolved Hide resolved
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore me! Just was a comment change

@kodiakhq kodiakhq bot merged commit 1574611 into carbon-design-system:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for narrow grid mode and update gutter classes
3 participants