Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CodeSnippet): overhaul storybook #6606

Merged

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Aug 4, 2020

Closes #6592

Overhauls and streamlines CodeSnippet stories. All knobs are now in 'playground'.

Testing / Reviewing

Make sure all functionality we want to demonstrate is accounted for and working correctly 👍

@dakahn dakahn requested a review from a team as a code owner August 4, 2020 01:27
@netlify
Copy link

netlify bot commented Aug 4, 2020

Deploy preview for carbon-elements ready!

Built with commit 3ce6c12

https://deploy-preview-6606--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3ce6c12

https://deploy-preview-6606--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

Removing review requests as it's WIP 👀

@dakahn dakahn changed the title [WIP]docs(CodeSnippet): overhaul storybook docs(CodeSnippet): overhaul storybook Aug 6, 2020
@dakahn
Copy link
Contributor Author

dakahn commented Aug 6, 2020

Probably good to get some eyes on this 👀

<Preview>
<Story id="codesnippet--code-snippet" />
</Preview>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be helpful to talk about the different variations as top-level headings, maybe the following each with their own default example:

  • Inline
  • Multi-line
  • Single-line

At a top-level, it might be helpful to address a couple of common situations:

  • Copying a code snippet
    • How to enable/disable
    • How to configure the feedback provided
  • Rendering a "light" variant, and when/why to use that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added individual sections for the different use cases (inline, multi, light etc) -- seemed a little redundant to describe turning the copy button off and on and stuff with the API and expected boolean listed in the props table though, but I can go back and add that if we think it's something we need.

@joshblack
Copy link
Contributor

Need anything else for this PR @dakahn ? 👀

@dakahn
Copy link
Contributor Author

dakahn commented Aug 19, 2020

No @joshblack, my bad it's gone so stale. I'll get this patched up by EOD

@dakahn dakahn force-pushed the 6592-update-codesnippet-docs branch from 2cfe261 to 60cf893 Compare August 19, 2020 23:32
@dakahn dakahn requested a review from joshblack August 19, 2020 23:32
@dakahn dakahn requested a review from tw15egan August 20, 2020 18:39
@dakahn dakahn requested a review from tw15egan August 20, 2020 19:02
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakahn dakahn merged commit 99816ba into carbon-design-system:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for Code Snippet
3 participants