feat(eslint): enable button-has-type rule #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 782dd2a |
|
Deploy preview for carbon-components-react ready! Built with commit 782dd2a https://deploy-preview-6612--carbon-components-react.netlify.app |
emyarod
reviewed
Aug 5, 2020
|
Just updated snapshots, will check back in when the build finishes 👀 |
tw15egan
approved these changes
Aug 5, 2020
emyarod
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rule for
button-has-typeto make sure we explicitly annotate buttons with a type. This catches a frequent bug we have for buttons where they don't havetype="button"Changelog
New
react/button-has-typeruleChanged
type="button"to buttonsRemoved