-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint): enable button-has-type rule #6612
feat(eslint): enable button-has-type rule #6612
Conversation
Deploy preview for carbon-elements ready! Built with commit 782dd2a |
Deploy preview for carbon-components-react ready! Built with commit 782dd2a https://deploy-preview-6612--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, pending snapshot updates
Just updated snapshots, will check back in when the build finishes 👀 |
Add rule for
button-has-type
to make sure we explicitly annotate buttons with a type. This catches a frequent bug we have for buttons where they don't havetype="button"
Changelog
New
react/button-has-type
ruleChanged
type="button"
to buttonsRemoved