Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): update tests from DAP to AC #7506

Merged

Conversation

joshblack
Copy link
Contributor

This PR is some clean-up for some of our old AAT files as they relate to DAP. It removes DAP files, matchers, and updates test files to use the new AC matcher.

Changelog

New

Changed

  • Update Jest config to omit toHaveNoDAPViolations
  • Update test files to use toHaveNoACViolations

Removed

  • aat folder was removed
  • toHaveNoDAPViolations was removed

@joshblack joshblack requested a review from a team as a code owner January 5, 2021 22:58
@joshblack joshblack enabled auto-merge (squash) January 5, 2021 23:00
@joshblack
Copy link
Contributor Author

FYI @dakahn

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 0a468f6

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffdfe6e666a990008b65b2c

😎 Browse the preview: https://deploy-preview-7506--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0a468f6

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffdfe6e3709d00007648bf6

😎 Browse the preview: https://deploy-preview-7506--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack
Copy link
Contributor Author

bump @andreancardona let me know if you have any questions!

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josh looks good!

@joshblack joshblack merged commit 94c4b90 into carbon-design-system:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants