fix(checkbox): fixed the checkbox component bidi layout issue. (#7524) #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-design-system#7524) Fixed the tick orientation for checkbox component in bidi(RTL) layout by adding the RTLCSS value directives. (carbon-design-system#7524)
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 74d3a21 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/60010146b84c1a000771a9d1 😎 Browse the preview: https://deploy-preview-7564--carbon-elements.netlify.app |
|
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: 74d3a21 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/600101464e476e00089bb163 😎 Browse the preview: https://deploy-preview-7564--carbon-components-react.netlify.app |
joshblack
approved these changes
Jan 14, 2021
aledavila
approved these changes
Jan 14, 2021
|
Thanks @DavidSCChen would you mind fixing the merge conflicts please |
|
Thanks for the review, I had resolved the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7524
Fixed the tick orientation for checkbox component in bidi(RTL) layout by adding the RTLCSS value directives.
Changelog
New
Added RTLCSS value directives in to the _checkbox.scss.
Testing / Reviewing
Verified the fix has no impact to the ltr layout by using the local storybook development server.
Also created the sandbox to verify the rtl layout:
https://codesandbox.io/s/webpack-react-rtlcss-carbon-checkbox-fixed-j1iyy