fix(Tag): pass disabled state to tag button #8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also modify the |
|
Deploy preview for carbon-elements ready! Built with commit 36a4d34 |
|
Deploy preview for carbon-components-react ready! Built with commit 36a4d34 https://deploy-preview-8297--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit dd7776c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit dd7776c https://deploy-preview-8297--carbon-components-react.netlify.app |
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7160
Refs #4792
Refs #6925
Prevents
onClickfrom firing on aninteractivetag when it is disabled.Changelog
New
Tagis an interactive tag (button), passes along the disabled state to prevent click actionsTesting / Reviewing
Set the
disabledknob to true for the defaultTagstory. Ensure no actions are logged when clicking on the disabled tags