-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tag): pass disabled state to tag button #8297
Conversation
We could also modify the |
Deploy preview for carbon-elements ready! Built with commit 36a4d34 |
Deploy preview for carbon-components-react ready! Built with commit 36a4d34 https://deploy-preview-8297--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit dd7776c |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit dd7776c https://deploy-preview-8297--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Closes #7160
Refs #4792
Refs #6925
Prevents
onClick
from firing on aninteractive
tag when it is disabled.Changelog
New
Tag
is an interactive tag (button
), passes along the disabled state to prevent click actionsTesting / Reviewing
Set the
disabled
knob to true for the defaultTag
story. Ensure no actions are logged when clicking on the disabled tags