Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(data-table): remove unused style block #9242

Merged
merged 2 commits into from
Jul 29, 2021
Merged

refactor(data-table): remove unused style block #9242

merged 2 commits into from
Jul 29, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 21, 2021

Closes #9237

related #5209

This PR removes an unused style block in the core data table styles

@emyarod emyarod requested a review from a team as a code owner July 21, 2021 15:11
@emyarod emyarod requested review from tw15egan and jnm2377 July 21, 2021 15:11
@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 31fe5ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6102e1a8b4034e0008ecf454

😎 Browse the preview: https://deploy-preview-9242--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 31fe5ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6102e1a81aff360008d8a4b9

😎 Browse the preview: https://deploy-preview-9242--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 31fe5ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6102e1a865f45d00084a132f

😎 Browse the preview: https://deploy-preview-9242--carbon-components-react.netlify.app

@emyarod emyarod requested a review from a team July 22, 2021 16:54
@kodiakhq kodiakhq bot merged commit cb374d8 into carbon-design-system:main Jul 29, 2021
@emyarod emyarod deleted the 9237-remove-unused-table-select-all-style branch July 29, 2021 17:40
This was referenced Aug 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in _data-table-core.scss
3 participants
@emyarod @joshblack @tw15egan