Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Type): add new type tokens #9480

Merged
merged 14 commits into from
Aug 30, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Aug 16, 2021

Closes #9377

This PR adds in a few new type tokens, as well as aliasing old type-token names to their new V11 token name. The old values will be removed in V12.

Changelog

New

  • legal-01 and legal-02 added as net new tokens

Changed

-Old token names are set as values of token names in blue

Screen Shot 2021-08-16 at 1 48 11 PM

Removed

  • No code should have been removed, and all old tokens should still work

Testing / Reviewing

Token values have been set to align with the Notion doc

@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7320872

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612d348ff629280008c50159

😎 Browse the preview: https://deploy-preview-9480--carbon-react-next.netlify.app/

@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7320872

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612d348f6102f700088ea2a1

😎 Browse the preview: https://deploy-preview-9480--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7320872

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612d348f3453a700076bca14

😎 Browse the preview: https://deploy-preview-9480--carbon-components-react.netlify.app

@tw15egan
Copy link
Member Author

@laurenmrice @janchild can you take a look at the elements preview before we merge?

https://deploy-preview-9480--carbon-elements.netlify.app/type/examples/preview/

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I inspected all of the type tokens and found a couple of discrepancies. They should be changed to the following:

helper-text-02 should be:
Letter spacing: .16px

For heading-compact-01 and heading-compact-02, the Computed tab was not showing the line height and letter spacing for me, and they looked the same size so just double checking that they should be this:

heading-compact-01 should be:
Size: 14px / 0.875rem
Line height: 18px / 1.125rem
Letter spacing: .16px

heading-compact-02 should be:
Size: 16px / 1rem
Line height: 22px / 1.375rem
Letter spacing: 0px

quotation-01 and fluid-quotation-01 should be using IBM Plex Serif instead of Sans.
quotation-02 and fluid-quotation-02 should be using IBM Plex Serif instead of Sans.

heading-01 andexpressive-heading-01should be:
Line height: 20px / 1.25rem

heading-02 and expressive-heading-02 should be:
Line height: 24px / 1.5rem

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked again today after changes and it looks good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Token changes
5 participants