-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(carbon-react): added dependencies for better install experience #9533
chore(carbon-react): added dependencies for better install experience #9533
Conversation
Please correct me if I'm wrong, but I thought peer dependencies still require you to install the dependencies? But actual dependencies won't need to be installed? I think the better option would be to go with dependencies in that case so people don't actually have to install these. However, if peer dependencies don't require installation on their end, then it's cool 👍🏽 |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 4e6d55f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6127c13cda25ff00079ddc8c 😎 Browse the preview: https://deploy-preview-9533--carbon-react-next.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 4e6d55f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6127c13c64f7ed0008e95f4f 😎 Browse the preview: https://deploy-preview-9533--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 4e6d55f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6127c13cf7b9270008c4066f 😎 Browse the preview: https://deploy-preview-9533--carbon-components-react.netlify.app |
This reverts commit 1338b29.
thanks for the heads up! |
Closes #9529
Added
carbon-components
andcarbon-icons
to the Dependencies for a better@carbon/react
installation experience. Users should no longer receive the following warnings on install.