Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tootlip): fixes tabbing issue #9545

Merged
merged 4 commits into from
Aug 31, 2021
Merged

fix(tootlip): fixes tabbing issue #9545

merged 4 commits into from
Aug 31, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #9469

Testing

  • There is a TEST storybook for the tooltip

  • Make sure tabbing allows you to open different tooltip, and closes the previous tooltip

We do not want open tooltips overlapping while TABBING through as reported in the issue above

  • Please make sure to remove TEST storybook before merging

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d8a6931

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612e5a1cf03bcf0008493d6c

😎 Browse the preview: https://deploy-preview-9545--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d8a6931

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612e5a1c04b31c0009f01493

😎 Browse the preview: https://deploy-preview-9545--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d8a6931

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612e5a1c0fb366000700d25d

😎 Browse the preview: https://deploy-preview-9545--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once test story is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tooltip] remains open when focus moves to other elements on the page
3 participants