Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toggle): make props.labelA and props.labelB optional #9550

Merged

Conversation

janhassel
Copy link
Member

Makes the labelA and labelB prop on the Toggle-next (v11 version) optional as they have sensible defaults and aren't shown (and therefore shouldn't be required) when hideLabel is passed.

Changelog

Changed

  • Made props.labelA and props.labelB optional

@janhassel janhassel requested a review from a team as a code owner August 27, 2021 10:10
@netlify
Copy link

netlify bot commented Aug 27, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ed017c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61311646bfbf2300078ff644

😎 Browse the preview: https://deploy-preview-9550--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ed017c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/613116461922b10007f7e2c2

😎 Browse the preview: https://deploy-preview-9550--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ed017c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/613116461922b10007f7e2be

😎 Browse the preview: https://deploy-preview-9550--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 355088c into carbon-design-system:main Sep 2, 2021
@janhassel janhassel deleted the toggle-labelab-required branch September 3, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants