Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Multiselect): add itemToElement to Multiselect #9559

Merged
merged 6 commits into from
Aug 31, 2021
Merged

feat(Multiselect): add itemToElement to Multiselect #9559

merged 6 commits into from
Aug 31, 2021

Conversation

tw15egan
Copy link
Member

Closes #9557

Adds in itemToElement support to Multiselect so that it functions similarly to Dropdown and Combobox

Changelog

New

  • itemToElement prop added to Multiselect and FilterableMultiselect

Changed

  • Added a story for easier testing

Testing / Reviewing

Go to the Item To Element story under MultiSelect and ensure the component renders as expected and is still searchable.

@tw15egan tw15egan requested a review from a team as a code owner August 30, 2021 11:56
@netlify
Copy link

netlify bot commented Aug 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: f88af0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612e521e5813d60007242495

😎 Browse the preview: https://deploy-preview-9559--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: f88af0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612e521e5813d6000724248d

😎 Browse the preview: https://deploy-preview-9559--carbon-elements.netlify.app

@tw15egan tw15egan requested a review from a team as a code owner August 30, 2021 12:16
@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: ddedc83

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612cc781d83b71000818e430

😎 Browse the preview: https://deploy-preview-9559--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 9c71d84

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612ccc295b02a200076c2bd5

😎 Browse the preview: https://deploy-preview-9559--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: f88af0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612e521e4f002e00075c2a17

😎 Browse the preview: https://deploy-preview-9559--carbon-components-react.netlify.app

andreancardona
andreancardona approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending Josh's question, looks good :)

@kodiakhq kodiakhq bot merged commit fdff63e into carbon-design-system:main Aug 31, 2021
This was referenced Sep 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@andreancardona andreancardona andreancardona approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support rendering items as node for MultiSelect
3 participants
@tw15egan @joshblack @andreancardona