fix(tile): added deprecation warnings for v11 #9571
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 34392a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6137bd9bf995cc0007ccb25c 😎 Browse the preview: https://deploy-preview-9571--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 34392a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6137bd9b093e30000792a8ec 😎 Browse the preview: https://deploy-preview-9571--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 34392a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6137bd9b0123440007b9a3fc 😎 Browse the preview: https://deploy-preview-9571--carbon-components-react.netlify.app |
sstrubberg
changed the title
There was a problem hiding this comment.
Looking great! Just left a style nit comment, the only other thing that came to mind was if we needed to use React.forwardRef here.
Sometimes, our class components are used in a way where people are passing in a ref to them and they consider it a breaking change if ref no longer works for a component. I'm not sure what the best way forward is with this and would love to hear your thoughts on if we should go for the functional components or if React.forwardRef may be an okay compromise 👀
Refactored most of Tile to be a Functional component and added deprecation warnings for handleClick and handleKeyDown. Added deprecation warnings to Button as well.
Halp
Tests are failing all over the place. Could use another set of eyes.