Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add initial content switcher refactor #9576

Merged
merged 5 commits into from
Sep 8, 2021
Merged

feat(react): add initial content switcher refactor #9576

merged 5 commits into from
Sep 8, 2021

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Aug 31, 2021 •
edited
Loading

Initial implementation of #9519

This PR adds in a base implementation and API for the new ContentSwitcher component

Changelog

New

  • Add initial implementation of ContentSwitcher for v11

Changed

Removed

Testing / Reviewing

  • Pull down the PR locally and run the storybook in packages/react
  • Comment the line in next/ContentSwitcher-story.js that says includeStories: []
  • Try out the story and make sure that the ContentSwitcher works with both keyboard and mouse for switching the panels

@netlify
Copy link

netlify bot commented Aug 31, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 955aa47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61391da7a7a11800070d2924

😎 Browse the preview: https://deploy-preview-9576--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 31, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 955aa47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61391da71b0a8c0007500c16

😎 Browse the preview: https://deploy-preview-9576--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 31, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 955aa47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61391da7797c390007761175

😎 Browse the preview: https://deploy-preview-9576--carbon-components-react.netlify.app

@joshblack joshblack marked this pull request as ready for review September 2, 2021 20:25
@joshblack joshblack requested a review from a team as a code owner September 2, 2021 20:25
tw15egan
tw15egan approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab focus working as expected, arrow key navigation working, selection via enter / spacebar working, and no accessibility violations 👍🏻 ✅

dakahn
dakahn approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out on Edge 👍🏾

@kodiakhq kodiakhq bot merged commit f9008be into carbon-design-system:main Sep 8, 2021
This was referenced Sep 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @tw15egan @dakahn