-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): update notification to new token format #9582
fix(styles): update notification to new token format #9582
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 6d925f4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6130b1ad30c227000827e33f 😎 Browse the preview: https://deploy-preview-9582--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6d925f4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6130b1ad2a0aec0007203a5f 😎 Browse the preview: https://deploy-preview-9582--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6d925f4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6130b1ad0408830007f1e51a 😎 Browse the preview: https://deploy-preview-9582--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! The toast notification playground story looks great 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 🎉
Part of #9358
Our component token strategy currently requires teams to pass in the component tokens to the
theme
mixin directly in order for component tokens to work across themes. This PR updatesnotification
so that its component tokens work in different themes and introduces a way to automatically register component tokens in the theme.Changelog
New
themes
packageChanged
*.stories.js
files for prop type warningsRemoved
Testing / Reviewing
lowContrast
in controls