-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress-indicator): fix active state #9740
fix(progress-indicator): fix active state #9740
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: ca8800e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/616cbe36cbf5400008170e96 😎 Browse the preview: https://deploy-preview-9740--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a74eb8a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614e0f1fb2803e00080bc5e5 😎 Browse the preview: https://deploy-preview-9740--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a74eb8a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614e0f1f357b1e0007ec43ec 😎 Browse the preview: https://deploy-preview-9740--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: ca8800e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616cbe36f7474f00070d5605 😎 Browse the preview: https://deploy-preview-9740--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: ca8800e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616cbe3675050e0008f591ee 😎 Browse the preview: https://deploy-preview-9740--carbon-elements.netlify.app |
Testing out the storybook preview this seems to also add the Would |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, wrong button click 🤦 Quick +1 to Jan's comments above
@janhassel Hey Jan! Good catch, just pushed up your fix. :) |
packages/components/src/components/progress-indicator/_progress-indicator.scss
Show resolved
Hide resolved
DCO Assistant Lite bot All contributors have signed the DCO. |
recheck |
packages/styles/scss/components/progress-indicator/_progress-indicator.scss
Outdated
Show resolved
Hide resolved
…#9898) ### Related Ticket(s) carbon-design-system#9740 ### Description Adds custom event after `selectable-tile` is selected ### Changelog **New** - `bx-selectable-tile-changed` custom event added to `selectable-tile` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Closes #9733
This PR adds the :active state to interactive steps that do not have a tooltip. Checkout original issue for full details.
:active