Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Web components): configure docs in storybook #6478

Conversation

sangeethababu9223
Copy link
Member

Closes #6423

The current storybook for web components does not include docs, configure the same.

What did you change?

Updated storybook configuration to show content from *.mdx files to show in the docs section.

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 1fb0ae8
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673ef9672bac3a0008021b28
😎 Deploy Preview https://deploy-preview-6478--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1fb0ae8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673ef9676b822e0008b10097
😎 Deploy Preview https://deploy-preview-6478--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (01ece2b) to head (1fb0ae8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6478      +/-   ##
==========================================
- Coverage   79.64%   79.62%   -0.02%     
==========================================
  Files         394      394              
  Lines       12886    12886              
  Branches     4268     4268              
==========================================
- Hits        10263    10261       -2     
- Misses       2623     2625       +2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)
---- 🚨 Try these New Features:

@elycheea
Copy link
Contributor

Should double check if #6300 changes are included since we closed that as a duplicate.

@sangeethababu9223
Copy link
Member Author

Should double check if #6300 changes are included since we closed that as a duplicate.

I've double checked with closed issue:

  • Docs tab is working as expected now.
  • Imports are updated.
  • For links to samples, since we don't have stackblitz samples set up for web components and the ones in .mdx files point to core carbon, this section is removed. we could update this once we have set up stackblitz samples for web components package.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review November 21, 2024 09:23
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner November 21, 2024 09:23
@sangeethababu9223 sangeethababu9223 requested review from makafsal and anamikaanu96 and removed request for a team November 21, 2024 09:23
@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@matthewgallo matthewgallo added this pull request to the merge queue Nov 21, 2024
Merged via the queue into carbon-design-system:main with commit cdd0b8e Nov 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web components storybook: configure docs
3 participants