Skip to content

Commit

Permalink
docs: update README/CONTRIBUTING
Browse files Browse the repository at this point in the history
  • Loading branch information
metonym committed Apr 9, 2024
1 parent 945c6e2 commit 6ace5fd
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 23 deletions.
31 changes: 11 additions & 20 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Prerequisites

For MacOS, prerequisites include [Node.js](https://nodejs.org/en/download/package-manager/#macos)(version 12 or greater) and [Yarn](https://yarnpkg.com/en/docs/install#mac-stable).
[Bun](https://bun.sh/docs/installation).

## Set-up

Expand All @@ -24,33 +24,24 @@ git remote -v
Finally, install the project dependencies:

```sh
yarn install
bun install
```

## Workflow

### Unit tests

Ensure the unit tests pass by running `yarn test:unit`.
Ensure the unit tests pass by running `bun test`.

### Integration tests
### End-to-end (e2e) tests

Because this library is written in TypeScript, it must be transpiled to JavaScript before it can be used by integration tests in the `integration` folder.
Because this library is written in TypeScript, it must be transpiled to JavaScript before it can be used by e2e tests in the `tests/e2e` folder.

Run `yarn build` to build the library. The transpiled JavaScript code is emitted to the `lib` folder.
Run `bun run build` to build the library. The transpiled JavaScript code is emitted to the `lib` folder.

To build the library in watch mode, run `yarn build:watch`.
To build the library in watch mode, run `bun run build -w`.

### Continuous Integration

The `yarn prepack` command is executed in Travis CI.

It does the following:

1. Build the library
2. Run unit/svelte-check/integration tests in parallel

The CI should pass if no unexpected errors occur.
Then, run `bun test:e2e` to run the e2e tests.

## Submitting a Pull Request

Expand All @@ -60,10 +51,10 @@ Before submitting a pull request, make sure your fork is up to date with the lat

```sh
git fetch upstream
git checkout master
git merge upstream/master
git checkout main
git merge upstream/main
```

### Submit a PR

After you've pushed your changes to remote, submit your PR. Make sure you are comparing `<YOUR_USER_ID>/feature` to `origin/master`.
After you've pushed your changes to remote, submit your PR. Make sure you are comparing `<YOUR_USER_ID>/feature` to `origin/main`.
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,17 @@ This library adopts a progressively enhanced approach. Any property type that ca
Install `sveld` as a development dependency.

```sh
yarn add -D sveld
# OR
# npm
npm i -D sveld
# OR

# pnpm
pnpm i -D sveld

# Bun
bun i -D sveld

# Yarn
yarn add -D sveld
```

### Rollup
Expand Down

0 comments on commit 6ace5fd

Please sign in to comment.