-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idiomatic code performance and developer-facing docs to goals #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new tools has a higher cost than many people appreciate." --
John Carmack
I believe should be:
new tools has a higher cost than many people appreciate."
--John Carmack
Your reference prefers em dash (which as an aside, by https://developers.google.com/style/dashes, would have no spaces around it). This is what I was doing before #116; there, I altered the style to |
Higher up on that page is what I was referring to:
The source of an epigraph is usually given on a line following the
quotation, sometimes preceded by a dash.
Nowhere on that page is it suggesting that there should be no whitespace
between the epigraph and the source.
…On Wed, Jul 22, 2020 at 3:07 PM Jon Meow ***@***.***> wrote:
new tools has a higher cost than many people appreciate." --
John Carmack <https://twitter.com/id_aa_carmack/status/989951283900514304>
I believe should be:
new tools has a higher cost than many people appreciate."
--John Carmack
<https://twitter.com/id_aa_carmack/status/989951283900514304>
https://english.stackexchange.com/questions/28601/appropriate-dash-to-use-when-attributing-a-quotation#:~:text=Let%20a%20dash%20precede%20the,both)%20following%20a%20direct%20quotation.&text=In%20contemporary%20usage%2C%20block%20quotes,make%20the%20quotation%20stand%20out
.
Your reference prefers em dash (which as an aside, by
https://developers.google.com/style/dashes, would have no spaces around
it). This is what I was doing before #116
<#116>; there, I
altered the style to " -- " instead of an em dash, stemming from related
conversation on the goals PR. There are spaces because I find "text--text"
hard to read. Once the spaces are present, the rest is just a matter of
word wrap.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUNHVYCB6AOXEKIDBXPES3R45PI7ANCNFSM4PFCGN2Q>
.
--
Josh
|
I think I understand what you want now, done. |
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good; just a few wording suggestions.
Co-authored-by: Geoff Romer <gromer@google.com> Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proposals/p0120.md
Outdated
Additionally, while considering justification for changes in | ||
[PR 80](https://github.com/carbon-language/carbon-lang/pull/80), I noted there | ||
is no explicit goal to provide developer-facing documentation. I believe this is | ||
and intended part of the community goals, and could be inferred from current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/and intended/an intended/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Proposal accepted, no new requests since
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposal accepted, decision created.
- [RFC topic](https://forums.carbon-lang.dev/t/rfc-add-idiomatic-code-performance-and-developer-facing-docs-to-goals/105) - [Decision](https://forums.carbon-lang.dev/t/request-for-decision-add-idiomatic-code-performance-and-developer-facing-docs-to-goals/116) Co-authored-by: Chandler Carruth <chandlerc@gmail.com> Co-authored-by: Geoff Romer <gromer@google.com> Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com> Most of this is addressing issue #106. Two new explicit sub-goals: - Idiomatic code should be performant, stemming from #106. - User-facing documentation, separate thought from #83 discussion. I think both of these are on people's minds and assumed, but still worth spelling out.
Most of this is addressing issue #106.
Two new explicit sub-goals:
I think both of these are on people's minds and assumed, but still worth spelling out.