Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design overview update part 2 #1325

Merged
merged 21 commits into from
Jun 12, 2022
Merged

Design overview update part 2 #1325

merged 21 commits into from
Jun 12, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Jun 10, 2022

This follows #1274 . It mainly fills in the "generics" section, with smaller updates to other section.

@josh11b josh11b requested review from a team as code owners June 10, 2022 17:46
chandlerc
chandlerc approved these changes Jun 11, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

Some generally minor suggestions/comments inline. If the suggestions work, feel free to merge. At least one of them is a bit interesting though, so happy to follow-up if you'd like to try a different approach.

docs/design/README.md Outdated
#### Name lookup for common types

FIXME: should this be renamed to "The prelude"?
> **TODO:** should this be renamed to "The prelude"?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we include the keywords, probably not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
josh11b and others added 3 commits June 12, 2022 15:29
@josh11b @chandlerc
Apply suggestions from code review
d8f39b8 
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
@josh11b
Fix formatting
335cdc0
@josh11b
Delete TODO
e166a58
@josh11b josh11b merged commit 681f6b5 into carbon-language:trunk Jun 12, 2022
@josh11b josh11b deleted the second branch June 12, 2022 22:36
@josh11b josh11b mentioned this pull request Jun 13, 2022
Merged
josh11b added a commit that referenced this pull request Jun 14, 2022
@josh11b @chandlerc
Design overview update part 3: Safety (#1328)
fa8996a 
This follows #1274 and #1325 and fills in the "safety" section. It only covers our approach in general terms.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
@josh11b josh11b mentioned this pull request Jun 16, 2022
Merged
josh11b added a commit that referenced this pull request Jun 28, 2022
@josh11b @chandlerc @geoffromer
Design overview update part 4: C and C++ Interop (#1336)
bdb44ca 
This follows #1274 , #1325 , and #1328 . It fills in the "Bidirectional interoperability with C and C++" section.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Co-authored-by: Geoff Romer <gromer@google.com>
chandlerc added a commit that referenced this pull request Jun 28, 2022
@josh11b @chandlerc
Design overview update part 2 (#1325)
504a4b1 
This follows #1274 . It mainly fills in the "generics" section, with smaller updates to other section.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
chandlerc added a commit that referenced this pull request Jun 28, 2022
@josh11b @chandlerc
Design overview update part 3: Safety (#1328)
d37dfd2 
This follows #1274 and #1325 and fills in the "safety" section. It only covers our approach in general terms.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
chandlerc added a commit that referenced this pull request Jun 28, 2022
@josh11b @chandlerc @geoffromer
Design overview update part 4: C and C++ Interop (#1336)
fbf353a 
This follows #1274 , #1325 , and #1328 . It fills in the "Bidirectional interoperability with C and C++" section.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Co-authored-by: Geoff Romer <gromer@google.com>
@josh11b josh11b mentioned this pull request Jun 28, 2022
Merged
josh11b added a commit that referenced this pull request Jul 6, 2022
@josh11b @zygoloid @chandlerc
Design overview update part 5: Names (#1347)
5535f5e 
This follows #1274 , #1325 , #1328 , and #1336 . It fills in the "Names" section.

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
@josh11b josh11b mentioned this pull request Jul 7, 2022
Merged
josh11b added a commit that referenced this pull request Jul 8, 2022
@josh11b @jonmeow
Design overview update part 6 (#1368)
77df7c5 
This follows #1274 , #1325 , #1328 , #1336 , and #1347 . This has miscellaneous changes to the design overview without a particular focus.

Also adds some missing keywords to our list of keywords.

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
@josh11b josh11b mentioned this pull request Jul 11, 2022
Merged
josh11b added a commit that referenced this pull request Jul 15, 2022
@josh11b @geoffromer
@zygoloid @chandlerc
Design overview update part 7: values (#1378)
53053e5 
This follows #1274 , #1325 , #1328 , #1336 , #1347 , and #1368 . This fills in details about how values work, value categories, parameter passing, unformed state, and so on.

Co-authored-by: Geoff Romer <gromer@google.com>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @chandlerc